[PR #253] [MERGED] scpair: More reliability improvements #261

New issue

Closed

opened 2026-10-22 05:08:25 +00:00 by roman · 0 comments

roman commented

2026-10-22 05:08:25 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/safijari/openpuck/pull/253
Author: @Leseratte10
Created: 8/24/2026
Status: ✅ Merged
Merged: 9/3/2026
Merged by: @safijari

Base: main ← Head: scpair-conn

📝 Commits (1)

8f57396 scpair: Reliability improvements

📊 Changes

1 file changed (+87 additions, -36 deletions)

View changed files

📝 ReversePuck/scpair.py (+87 -36)

📄 Description

A few more improvements to the scpair.py script:

Retry a controller request if it fails, instead of crashing
Retry a controller request if the controller responded to a different in-flight request by comparing rid and cmd from the request with the ones provided in the response.

The two features above are handled with a new self.set_get_request() function in the HidDev class which is now used instead of calling set_request then get_request. That way, timeouts, repeats and response data validation can happen centrally in one function.

Display if an OpenPuck runs in Puck or in Machine mode (will work after #242 is merged)
Display which of the two controller slots is currently in use (requires 0.9.43 or later; for wireless controllers this will show the slot the controller is currently connected to, for wired controllers this will show the slot the controller will connect to once unplugged).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/safijari/openpuck/pull/253 **Author:** [@Leseratte10](https://github.com/Leseratte10) **Created:** 8/24/2026 **Status:** ✅ Merged **Merged:** 9/3/2026 **Merged by:** [@safijari](https://github.com/safijari) **Base:** `main` ← **Head:** `scpair-conn` --- ### 📝 Commits (1) - [`8f57396`](https://github.com/safijari/openpuck/commit/8f57396dc34bff04a1b4e4bf9bc2b58bc52cda71) scpair: Reliability improvements ### 📊 Changes **1 file changed** (+87 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `ReversePuck/scpair.py` (+87 -36) </details> ### 📄 Description A few more improvements to the scpair.py script: - Retry a controller request if it fails, instead of crashing - Retry a controller request if the controller responded to a different in-flight request by comparing rid and cmd from the request with the ones provided in the response. The two features above are handled with a new `self.set_get_request()` function in the HidDev class which is now used instead of calling set_request then get_request. That way, timeouts, repeats and response data validation can happen centrally in one function. - Display if an OpenPuck runs in Puck or in Machine mode (will work after #242 is merged) - Display which of the two controller slots is currently in use (requires 0.9.43 or later; for wireless controllers this will show the slot the controller is currently connected to, for wired controllers this will show the slot the controller will connect to once unplugged). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

roman

2026-10-22 05:08:25 +00:00