[PR #315] [CLOSED] Power off controllers after USB host shutdown #284

New issue

Closed

opened 2026-10-22 05:08:41 +00:00 by roman · 0 comments

roman commented

2026-10-22 05:08:41 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/safijari/openpuck/pull/315
Author: @Copilot
Created: 10/14/2026
Status: ❌ Closed

Base: main ← Head: copilot/291

📝 Commits (1)

ba348f8 Power off controllers after USB host shutdown

📊 Changes

1 file changed (+27 additions, -16 deletions)

View changed files

📝 OpenPuck/haptics.cpp (+27 -16)

📄 Description

Summary

Fixes #291 by powering controllers off when the host shuts down without reporting USB suspend.

Changes

Detect a sustained USB unmount after OpenPuck has previously mounted.
Retain suspend detection, the four-second debounce, VBUS guard, and one-shot shutdown behavior.

Validation

make check passed.
make build could not run because arduino-cli is unavailable.
CodeQL reported no alerts; code review tool was unavailable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/safijari/openpuck/pull/315 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 10/14/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `copilot/291` --- ### 📝 Commits (1) - [`ba348f8`](https://github.com/safijari/openpuck/commit/ba348f81e8c04a47b35875bf952b3e4cfff2297d) Power off controllers after USB host shutdown ### 📊 Changes **1 file changed** (+27 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `OpenPuck/haptics.cpp` (+27 -16) </details> ### 📄 Description ## Summary Fixes #291 by powering controllers off when the host shuts down without reporting USB suspend. ## Changes - Detect a sustained USB unmount after OpenPuck has previously mounted. - Retain suspend detection, the four-second debounce, VBUS guard, and one-shot shutdown behavior. ## Validation - `make check` passed. - `make build` could not run because `arduino-cli` is unavailable. - CodeQL reported no alerts; code review tool was unavailable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

roman

2026-10-22 05:08:41 +00:00