[PR #252] [MERGED] Fix controller no longer shutting off regression #260

New issue

Closed

opened 2026-10-22 05:08:24 +00:00 by roman · 0 comments

roman commented

2026-10-22 05:08:24 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/safijari/openpuck/pull/252
Author: @safijari
Created: 8/24/2026
Status: ✅ Merged
Merged: 8/24/2026
Merged by: @safijari

Base: main ← Head: pr-247-fixes

📝 Commits (2)

01a83e3 Fix early return in hapticTask skipping host-sleep controller shutdown
8f99dc1 Fix suspend power-off wake trade-off and stale-slot "off!" delivery

📊 Changes

6 files changed (+116 additions, -50 deletions)

View changed files

📝 OpenPuck/config.cpp (+8 -1)
📝 OpenPuck/haptics.cpp (+64 -43)
📝 OpenPuck/haptics.h (+23 -6)
📝 OpenPuck/puck_hid.cpp (+6 -0)
📝 OpenPuck/serial_console.cpp (+10 -0)
📝 OpenPuck/webusb_config.cpp (+5 -0)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/safijari/openpuck/pull/252 **Author:** [@safijari](https://github.com/safijari) **Created:** 8/24/2026 **Status:** ✅ Merged **Merged:** 8/24/2026 **Merged by:** [@safijari](https://github.com/safijari) **Base:** `main` ← **Head:** `pr-247-fixes` --- ### 📝 Commits (2) - [`01a83e3`](https://github.com/safijari/openpuck/commit/01a83e39fda048237c3c74db1f9c6546086dcb83) Fix early return in hapticTask skipping host-sleep controller shutdown - [`8f99dc1`](https://github.com/safijari/openpuck/commit/8f99dc10540c78b02f67c49cb448f9ffe44a29bb) Fix suspend power-off wake trade-off and stale-slot "off!" delivery ### 📊 Changes **6 files changed** (+116 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `OpenPuck/config.cpp` (+8 -1) 📝 `OpenPuck/haptics.cpp` (+64 -43) 📝 `OpenPuck/haptics.h` (+23 -6) 📝 `OpenPuck/puck_hid.cpp` (+6 -0) 📝 `OpenPuck/serial_console.cpp` (+10 -0) 📝 `OpenPuck/webusb_config.cpp` (+5 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

roman

2026-10-22 05:08:24 +00:00