[PR #159] [MERGED] fix: CFG_TUD_HID=6 everywhere; delegate CI builds to make #234

New issue

Closed

opened 2026-10-22 05:08:00 +00:00 by roman · 0 comments

roman commented

2026-10-22 05:08:00 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/safijari/openpuck/pull/159
Author: @Copilot
Created: 7/9/2026
Status: ✅ Merged
Merged: 7/9/2026
Merged by: @safijari

Base: main ← Head: copilot/update-cfg-tud-hid-to-6

📝 Commits (1)

5388781 fix: set CFG_TUD_HID=6 everywhere; have CI use make build/reversepuck

📊 Changes

6 files changed (+21 additions, -47 deletions)

View changed files

📝 .github/workflows/build.yml (+2 -14)
📝 .github/workflows/release.yml (+3 -21)
📝 AGENTS.md (+1 -3)
📝 CODE_MAP.md (+1 -1)
📝 Makefile (+11 -5)
📝 docs/BUILD_AND_DEPLOY.md (+3 -3)

📄 Description

CI workflows hardcoded CFG_TUD_HID=4 inline, diverging silently from the Makefile's CFG_TUD_HID=6. This meant CI was compiling and shipping firmware with the wrong HID interface count.

Changes

CI workflows (build.yml, release.yml): Replace all inline arduino-cli compile invocations with make build, make reversepuck, and make build-recovery. Flag values now come from one place — the Makefile.
Makefile: Add optional BUILD_PATH / OUTPUT_DIR variables. When set, --clean --build-path … --output-dir … are injected automatically, giving CI artifact control without duplicating flags:
```
make build BUILD_PATH=build/cache/openpuck OUTPUT_DIR=build/openpuck
```
Propagated through all recursive $(MAKE) calls (build-recovery, deploy, reversepuck-deploy).
Docs / AGENTS.md / CODE_MAP.md: Update stale CFG_TUD_HID=4 and CFG_TUD_TASK_QUEUE_SZ=64 references to 6 / 512 to match Makefile reality.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/safijari/openpuck/pull/159 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 7/9/2026 **Status:** ✅ Merged **Merged:** 7/9/2026 **Merged by:** [@safijari](https://github.com/safijari) **Base:** `main` ← **Head:** `copilot/update-cfg-tud-hid-to-6` --- ### 📝 Commits (1) - [`5388781`](https://github.com/safijari/openpuck/commit/53887810fb6254141cba3914f5d8af971ea3299b) fix: set CFG_TUD_HID=6 everywhere; have CI use make build/reversepuck ### 📊 Changes **6 files changed** (+21 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+2 -14) 📝 `.github/workflows/release.yml` (+3 -21) 📝 `AGENTS.md` (+1 -3) 📝 `CODE_MAP.md` (+1 -1) 📝 `Makefile` (+11 -5) 📝 `docs/BUILD_AND_DEPLOY.md` (+3 -3) </details> ### 📄 Description CI workflows hardcoded `CFG_TUD_HID=4` inline, diverging silently from the Makefile's `CFG_TUD_HID=6`. This meant CI was compiling and shipping firmware with the wrong HID interface count. ## Changes - **CI workflows** (`build.yml`, `release.yml`): Replace all inline `arduino-cli compile` invocations with `make build`, `make reversepuck`, and `make build-recovery`. Flag values now come from one place — the Makefile. - **Makefile**: Add optional `BUILD_PATH` / `OUTPUT_DIR` variables. When set, `--clean --build-path … --output-dir …` are injected automatically, giving CI artifact control without duplicating flags: ``` make build BUILD_PATH=build/cache/openpuck OUTPUT_DIR=build/openpuck ``` Propagated through all recursive `$(MAKE)` calls (`build-recovery`, `deploy`, `reversepuck-deploy`). - **Docs / `AGENTS.md` / `CODE_MAP.md`**: Update stale `CFG_TUD_HID=4` and `CFG_TUD_TASK_QUEUE_SZ=64` references to `6` / `512` to match Makefile reality. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

roman

2026-10-22 05:08:00 +00:00