[PR #127] [MERGED] Gate firmware update tab behind ?beta=true #216

New issue

Closed

opened 2026-10-22 05:07:45 +00:00 by roman · 0 comments

roman commented

2026-10-22 05:07:45 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/safijari/openpuck/pull/127
Author: @Copilot
Created: 7/5/2026
Status: ✅ Merged
Merged: 7/5/2026
Merged by: @safijari

Base: main ← Head: copilot/gate-firmware-update-tab

📝 Commits (2)

d9dab96 Gate firmware update tab behind ?beta=true
2e6ee7f Use $ helper consistently in BETA_UI gate

📊 Changes

1 file changed (+6 additions, -0 deletions)

View changed files

📝 docs/index.html (+6 -0)

📄 Description

The firmware update tab and update-available pill are visible to all users, but the feature isn't ready for general availability. Gate both behind ?beta=true.

Changes

docs/index.html
- Added BETA_UI constant (mirrors existing DEBUG_UI pattern) reading ?beta=true from the URL
- Hides the "Firmware update" tab in #mainTabs and the #updAvail pill via inline style.display="none" when BETA_UI is false
- Inline style takes CSS precedence over the class-based .hide toggle in checkUpdateNotice(), preventing the pill from leaking through when not in beta mode

const BETA_UI = new URLSearchParams(location.search).get("beta")==="true";
if(!BETA_UI){
  $('#mainTabs .slot-tab[data-tab="tabUpdate"]').style.display="none";
  $("#updAvail").style.display="none";
}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/safijari/openpuck/pull/127 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 7/5/2026 **Status:** ✅ Merged **Merged:** 7/5/2026 **Merged by:** [@safijari](https://github.com/safijari) **Base:** `main` ← **Head:** `copilot/gate-firmware-update-tab` --- ### 📝 Commits (2) - [`d9dab96`](https://github.com/safijari/openpuck/commit/d9dab96e336964797a56c05bd06af71574924f9c) Gate firmware update tab behind ?beta=true - [`2e6ee7f`](https://github.com/safijari/openpuck/commit/2e6ee7fea7ebf3a0178b06be2f7f7bb9fb5a7370) Use $ helper consistently in BETA_UI gate ### 📊 Changes **1 file changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `docs/index.html` (+6 -0) </details> ### 📄 Description The firmware update tab and update-available pill are visible to all users, but the feature isn't ready for general availability. Gate both behind `?beta=true`. ## Changes - **`docs/index.html`** - Added `BETA_UI` constant (mirrors existing `DEBUG_UI` pattern) reading `?beta=true` from the URL - Hides the "Firmware update" tab in `#mainTabs` and the `#updAvail` pill via inline `style.display="none"` when `BETA_UI` is false - Inline style takes CSS precedence over the class-based `.hide` toggle in `checkUpdateNotice()`, preventing the pill from leaking through when not in beta mode ```js const BETA_UI = new URLSearchParams(location.search).get("beta")==="true"; if(!BETA_UI){ $('#mainTabs .slot-tab[data-tab="tabUpdate"]').style.display="none"; $("#updAvail").style.display="none"; } ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

roman

2026-10-22 05:07:45 +00:00