[PR #42] [MERGED] Rumble in all modes + SDL visibility fix #169

New issue

Closed

opened 2026-10-22 05:06:59 +00:00 by roman · 0 comments

roman commented

2026-10-22 05:06:59 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/safijari/openpuck/pull/42
Author: @safijari
Created: 6/16/2026
Status: ✅ Merged
Merged: 6/16/2026
Merged by: @safijari

Base: main ← Head: rumble

📝 Commits (3)

0b3281d Rumble should be fixed
106af57 rumble seems to work across all modes
3bde06c sdl apps now see controller

📊 Changes

12 files changed (+132 additions, -37 deletions)

View changed files

📝 OpenPuck/OpenPuck.ino (+10 -7)
📝 OpenPuck/haptics.cpp (+27 -4)
📝 OpenPuck/haptics.h (+3 -2)
📝 OpenPuck/identity.cpp (+1 -1)
📝 OpenPuck/identity.h (+1 -1)
📝 OpenPuck/mode_hidgyro.cpp (+12 -0)
📝 OpenPuck/mode_ps5.cpp (+41 -0)
📝 OpenPuck/mode_switch_pro.cpp (+16 -1)
📝 OpenPuck/mode_xinput.cpp (+10 -13)
📝 OpenPuck/puck_hid.cpp (+8 -5)
📝 OpenPuck/puck_hid.h (+1 -1)
📝 docs/PROTOCOL.md (+2 -2)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/safijari/openpuck/pull/42 **Author:** [@safijari](https://github.com/safijari) **Created:** 6/16/2026 **Status:** ✅ Merged **Merged:** 6/16/2026 **Merged by:** [@safijari](https://github.com/safijari) **Base:** `main` ← **Head:** `rumble` --- ### 📝 Commits (3) - [`0b3281d`](https://github.com/safijari/openpuck/commit/0b3281d054c1a2fbe33abf7dba8999e051905a16) Rumble should be fixed - [`106af57`](https://github.com/safijari/openpuck/commit/106af576c6be82bb94a55de9288bbc9c31d4ce72) rumble seems to work across all modes - [`3bde06c`](https://github.com/safijari/openpuck/commit/3bde06c8ae3e6075d4cf71573d63d6cac3b6e7f6) sdl apps now see controller ### 📊 Changes **12 files changed** (+132 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `OpenPuck/OpenPuck.ino` (+10 -7) 📝 `OpenPuck/haptics.cpp` (+27 -4) 📝 `OpenPuck/haptics.h` (+3 -2) 📝 `OpenPuck/identity.cpp` (+1 -1) 📝 `OpenPuck/identity.h` (+1 -1) 📝 `OpenPuck/mode_hidgyro.cpp` (+12 -0) 📝 `OpenPuck/mode_ps5.cpp` (+41 -0) 📝 `OpenPuck/mode_switch_pro.cpp` (+16 -1) 📝 `OpenPuck/mode_xinput.cpp` (+10 -13) 📝 `OpenPuck/puck_hid.cpp` (+8 -5) 📝 `OpenPuck/puck_hid.h` (+1 -1) 📝 `docs/PROTOCOL.md` (+2 -2) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

roman

2026-10-22 05:06:59 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

wontfix

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

safijari/openpuck#169

No description provided.

Rows
Columns